Fix all conformance failures other than timeouts/deadlines #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @perezd |
pkwarren
approved these changes
May 16, 2024
| @@ -36,3 +36,7 @@ internal class EndStreamResponseJSON( | |||
| @Json(name = "error") val error: ErrorPayloadJSON?, | |||
| @Json(name = "metadata") val metadata: Headers?, | |||
| ) | |||
|
|
|||
| internal fun contentTypeIsJSON(contentType: String): Boolean { | |||
| return contentType == "application/json" || contentType == "application/json; charset=utf-8" | |||
There was a problem hiding this comment.
Should we use MediaType to parse these reliably (we use this in ConnectOkHttpClient.kt)?
There was a problem hiding this comment.
Unfortunately, that is an okhttp type and helper function. But this is the library module, which intentionally does not have a dependency on okhttp.
This is what the Go implementation does, so despite being hacky, should be adequate. I'll add a TODO that this could be made more robust in the future.
pkwarren
approved these changes
May 17, 2024
rebello95
added a commit
to connectrpc/connect-swift
that referenced
this pull request
Jun 8, 2024
This PR includes updates to fix all outstanding conformance test failures and removes the corresponding opt-outs. All changes are validated by the conformance test suite. Many of these fixes are similar to connectrpc/connect-kotlin#248 and connectrpc/connect-kotlin#274. Resolves #268. Resolves #269. Resolves #270. This should also be one of the final changes before v1.0 #222. --------- Signed-off-by: Michael Rebello <[email protected]>
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two commits include fixes to the protocol logic to fix the known failures in conformance tests.
This still leaves the timeout/deadline propagation cases failing since those will require something more significant to resolve.
The third commit is just some minor updates to comments and TODOs that I figured I'd tweak while I was in these files. Hopefully they all make sense.
The final commit cleans up the known failing test case configuration -- to remove everything but the timeout/deadline tests.